Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44642 )
Change subject: soc/amd/common: add rudimentary ATIF support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44642/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44642/1//COMMIT_MSG@9 PS1, Line 9: kenerl drive
kernel driver
Done
https://review.coreboot.org/c/coreboot/+/44642/1/src/soc/amd/common/block/gr... File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/44642/1/src/soc/amd/common/block/gr... PS1, Line 101:
Do we need a default else case to handle a call with unexpected Arg0? Or just assume that the kernel […]
There's no notion of a consistent return value. I don't know what we could do there. The function bitmap is used to determine what other Arg0 sub functions to call and we're publishing only support for the brightness.