Attention is currently required from: Felix Singer, Jamie Ryu, Ethan Tsao, Ravishankar Sarawadi, Paul Menzel, Raj Astekar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
Any guidance/documentation on HOW-TOs for stage-wise Make build setup? Wondering when building coreboot.rom if it stubs out stages if not included.
I have tried creating a skeleton MTL board and select MTL SoC code to allow building only the bootblock code that you have added here.But unfortunately, it's too much changes that I had to make to resolve the code dependencies to allow this bootblock code to get successfully compiled.
I have noticed the main reasons for those compilation errors are due to inclusion of common code from SoC block, each common code block has some dependencies over other header files or the code block which is not added by this CL, hence, i had to keep on adding those, for example this CL selects `PCH_BASE` Kconfig from SoC code, now `PCH_BASE` kconfig internally selects GPIO Common code block, and GPIO common code block expects SoC code to have GPIO support. This has become circular dependencies.
IMO, we unfortunately need to add SoC code incrementally without hooking a MB code till we have SOC code ready with `ramstage` code changes.
Having said that, this CL need lots of rework to add only the bootblock code and corresponding header (which is not the case with this CL), so, please keep on adding those header files when you need those, rather dumping everything at once.
Please check the build failure https://qa.coreboot.org/job/coreboot-gerrit/200000/testReport/junit/(root)/b...