Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 54:
(42 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/b34ac849_4f0ccc4a PS54, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/cbc35971_561aa612 PS54, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/b260bbf5_cbc84012 PS54, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/d212d301_138bed7d PS54, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/3314f0f2_5278b4a6 PS54, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/4043c772_a38bf86b PS54, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/43881c21_9f1f730b PS54, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/9f574727_3146b17a PS54, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/e956dd8f_2be1675a PS54, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/8cb8e960_bbc00c23 PS54, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/07989986_16d7e5aa PS54, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/697e9342_f68481b1 PS54, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/d8d0adf0_26b92ea7 PS54, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/b949b66a_d6d1383b PS54, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/44e4e450_e4f10fdf PS54, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/0b7a0efa_5bcd4851 PS54, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/2c6fd5fe_1228ee92 PS54, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/659b697b_a8ed186f PS54, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/7be15f62_93639e64 PS54, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/2736b587_48b53bbc PS54, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/63920fdd_90043b5f PS54, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/380799b0_aed1f85e PS54, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/1d22536a_55aeaf72 PS54, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/0d7b5ac6_c5d8cbf1 PS54, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/a1d52cc0_5ac44cc6 PS54, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/8c88d6e8_dfd1bc3d PS54, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/ec5a96c4_5fee6730 PS54, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/b23cd43f_8245fb5b PS54, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/aca6a1bd_065e504d PS54, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/ac4ea57e_e881f9bc PS54, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/fdbf7b5a_b1f207b4 PS54, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/51bcacc4_a7022bfe PS54, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/fcd05d4a_1ff480a8 PS54, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/adfb9c0d_14115673 PS54, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/fb8eb963_40c67fb4 PS54, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/ed97199d_ea900a37 PS54, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/255683c4_76e37820 PS54, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/123a8389_c6413803 PS54, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/86bc9d9e_652bd076 PS54, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/d692bb6e_94ef7b4c PS54, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/cf509815_11df9ba4 PS54, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159858): https://review.coreboot.org/c/coreboot/+/23586/comment/252bb433_656d8307 PS54, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const