Attention is currently required from: Terry Chen, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64019 )
Change subject: mb/google/brya/variants/crota: Enable Bluetooth offload support ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/crota/gpio.c:
https://review.coreboot.org/c/coreboot/+/64019/comment/83a3789a_15198a48 PS3, Line 102: PAD_CFG_NF(GPP_VGPIO_30, NONE, DEEP, NF3), /* BT_I2S_BCLK */ : PAD_CFG_NF(GPP_VGPIO_31, NONE, DEEP, NF3), /* BT_I2S_SYNC */ : PAD_CFG_NF(GPP_VGPIO_32, NONE, DEEP, NF3), /* BT_I2S_SDO */ : PAD_CFG_NF(GPP_VGPIO_33, NONE, DEEP, NF3), /* BT_I2S_SDI */ : PAD_CFG_NF(GPP_VGPIO_34, NONE, DEEP, NF1), /* SSP2_SCLK */ : PAD_CFG_NF(GPP_VGPIO_35, NONE, DEEP, NF1), /* SSP2_SFRM */ : PAD_CFG_NF(GPP_VGPIO_36, NONE, DEEP, NF1), /* SSP_TXD */ : PAD_CFG_NF(GPP_VGPIO_37, NONE, DEEP, NF1), /* SSP_RXD */ Mention the source in the commit message.
File src/mainboard/google/brya/variants/crota/variant.c:
https://review.coreboot.org/c/coreboot/+/64019/comment/7f864963_95b3ae4b PS3, Line 9: config->cnvi_bt_audio_offload = 1; Please fix the indentation.