Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43661 )
Change subject: mb/google/vilboz: Tune I2C bus 3 clock ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@2 PS1, Line 2: peichao.wang
Please use *Peicho Wang*.
Done
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork/vilboz: Tune I2C bus 3 clock
Please look at other commits, how this is formulated. […]
Done
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@12 PS1, Line 12: measure I2C bus 3 clock : frequency less than 400KHz
It would be good to capture the actual measured frequency in the commit message. […]
Done
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@15 PS1, Line 15: Peichao.Wang
Please remove the dot between the names.
Done
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v... PS1, Line 31: .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */
Dear Paul, we need delete these comment, these values are correct for Vilboz. […]
Done