9 Feb
2022
9 Feb
'22
7:24 a.m.
Attention is currently required from: Subrata Banik, Christian Walter, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61721 )
Change subject: drivers/i2c/tpm/cr50: Add support to get and set BOARD_CFG register ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140335): https://review.coreboot.org/c/coreboot/+/61721/comment/be0ee524_6312d3b0 PS1, Line 592: if (cr50_i2c_write(CR50_BOARD_CFG(0), (uint8_t *)&board_cfg_value, sizeof(board_cfg_value))) line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/61721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fcfed9fa133db2560c4a855376d249e865c1335
Gerrit-Change-Number: 61721
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 20:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment