Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35459 )
Change subject: mb/google/hatch: Remove GPIO_DRIVER from pen eject GPIO configuration ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35459/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35459/1//COMMIT_MSG@18 PS1, Line 18: .
What about S3? That should work too.
Done
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... PS1, Line 34: PAD_CFG_GPI_SCI
Just a note: If any variants were relying on this pin for OS notifications, then that wouldn't work […]
At the time when we figured out the single-routing wouldn't work, I emailed all of the EEs and filed bugs for all the variants at the time to make sure they dual-routed the signal. I can check on the new ones that have come up since then.
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/... PS1, Line 34: LEVEL
This needs to be EDGE_SINGLE. Else, the device will wake up whenever the pen is left in the garage.
It wakes up if the pen is left out of the garage, will fix.