Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48113 )
Change subject: libpayload: Provide API to expose mmu memery ranges for all archs ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48113/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48113/2//COMMIT_MSG@13 PS2, Line 13: * Provide empty API for x86 and arm. Do we need this? I don't think it's useful to pretend that this API is universal, because MMU stuff works so different across architectures and that's likely always going to stay that way. I'd suggest to just keep this in arm64-specific headers and guard calls to it with CONFIG(LP_ARCH_ARM64) where necessary.
https://review.coreboot.org/c/coreboot/+/48113/2/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm64/mmu.c:
https://review.coreboot.org/c/coreboot/+/48113/2/payloads/libpayload/arch/ar... PS2, Line 709: const struct mmu_ranges *lib_get_mmu_ranges(void) The common prefix here is mmu_ so I'd just call this mmu_get_ranges() or something.