Attention is currently required from: Kyösti Mälkki, Martin L Roth, Michał Żygowski, Paul Menzel, Tim Wawrzynczak, Utkarsh H Patel.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/75286?usp=email )
Change subject: drivers/intel/dtbt: Add discrete Thunderbolt driver
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
Intel tried to remove support for FCM with Barlow Ridge, and then added it back for r1.1+. But it's basically unsupported and SCM should be used.
Duplicating all the SoC iTBT logic for SCM support doesn't seem great, but SoC code might have to be modified regardless of where dTBT is implemented.
File src/drivers/intel/dtbt/dtbt.c:
https://review.coreboot.org/c/coreboot/+/75286/comment/ca37c029_aaea9e6d?usp... :
PS10, Line 15: #define PCIE2TBT_GO2SX 2
: #define PCIE2TBT_GO2SX_NO_WAKE 3
: #define PCIE2TBT_SX_EXIT_TBT_CONNECTED 4
: #define PCIE2TBT_OS_UP 6
: #define PCIE2TBT_SET_SECURITY_LEVEL 8
: #define PCIE2TBT_GET_SECURITY_LEVEL 9
: #define PCIE2TBT_BOOT_ON 24
: #define PCIE2TBT_USB_ON 25
: #define PCIE2TBT_GET_ENUMERATION_METHOD 26
: #define PCIE2TBT_SET_ENUMERATION_METHOD 27
: #define PCIE2TBT_POWER_CYCLE 28
: #define PCIE2TBT_SX_START 29
: #define PCIE2TBT_ACL_BOOT 30
: #define PCIE2TBT_CONNECT_TOPOLOGY 31
Barlow Ridge (TBT5) only supports the mailbox commands: […]
`Set_Class_Code` was removed in r1.1, and `MaxPayloadSize` was documented.
- 0x11: `MayPayloadSize`
- 0x24: `GO2SLEEP`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75286?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib78ce43740956fa2c93b9ebddb0eeb319dcc0364
Gerrit-Change-Number: 75286
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-CC: Jeremy Soller
jeremy@system76.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 26 Aug 2024 18:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com