Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48182 )
Change subject: soc/amd: factor out common AOAC definitions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48182/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/aoac.h:
https://review.coreboot.org/c/coreboot/+/48182/1/src/soc/amd/common/block/in... PS1, Line 12: AOACx0000[40...7E] Maybe [40...7E:step2]. Same on l.25. The BKDGs used to use similar indicators but the PPRs are much harder to read IMO.