Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41086 )
Change subject: SMM: Validate more user-provided pointers ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... PS12, Line 337: break should this return instead?
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/braswell/smi... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/braswell/smi... PS12, Line 314: break should this return instead?
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/broadwell/sm... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/broadwell/sm... PS12, Line 361: break return?
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/common/block... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/common/block... PS12, Line 387: break return?
https://review.coreboot.org/c/coreboot/+/41086/12/src/southbridge/intel/lynx... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/southbridge/intel/lynx... PS12, Line 332: break return?