Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )
Change subject: Enable long cr50 ready pulses for Tigerlake systems ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43741/11/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/43741/11/src/drivers/spi/tpm/tpm.c@... PS11, Line 621: /* : * Read chunk_size bytes at a time, last chunk will be zero : * padded. : */ : do {
I am not sure if firmware version needs to be read in every stage. […]
Update on my previous comment:
Also with more than one use-case in ramstage, if the firmware version is already cached we can skip reading the firmware version. I believe it is not going to change within the ramstage.
It seems the idea is to do tlcl_lib_init() which is a No-op if it is already done. So that means we will not be reading the Firmware version multiple times in ramstage.
The other comment about reading firmware version in ramstage alone still holds. I don't see it being used in any other stages except for logging.