[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/xeon_sp: Use MemoryMapDataHob to add high RAM resources

[Angel Pons (Code Review)]

Attention is currently required from: Alicja Michalska, Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu.

Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84304?usp=email )

Change subject: soc/intel/xeon_sp: Use MemoryMapDataHob to add high RAM resources
......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84304/comment/c6748716_c1217795?usp... :
PS1, Line 9: window
Use plural: window*s*

https://review.coreboot.org/c/coreboot/+/84304/comment/479f6a24_b376ee87?usp... :
PS1, Line 10: no
typo: on

https://review.coreboot.org/c/coreboot/+/84304/comment/0544927c_8aec8212?usp... :
PS1, Line 13: mechanism for GNR and previous generation SoCs.
Has this change been tested? If so, on which platforms and how? I would recommend testing on previous generation platforms to make sure there are no regressions.

File src/soc/intel/xeon_sp/uncore.c:

https://review.coreboot.org/c/coreboot/+/84304/comment/4a5c3862_fef76db5?usp... :
PS1, Line 288:         const struct SystemMemoryMapHob *mm = get_system_memory_map();
> `code indent should use tabs where possible`

Please fix.