Attention is currently required from: Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case
......................................................................
Patch Set 11:
(1 comment)
File tests/lib/bootmem-test.c:
https://review.coreboot.org/c/coreboot/+/43510/comment/bf7eb1ea_bfcf32a6
PS11, Line 232: lb_mem = malloc(sizeof(*lb_mem) + 10 * sizeof(struct lb_memory_range));
Found by Coverity: you should initialize lb_mem->size (and ideally check that the function modified […]
Size (and tag) initialization is missing, you are right. But size is present in assert in test_bootmem_write_mem_table(). I think, that it is not necessary to add assert here as it will be checked in mentioned test. I just have to include initial size in assertion :)
Please look at: https://review.coreboot.org/c/coreboot/+/52263
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e539061ee5051d4158712a8a981a475ea7458a
Gerrit-Change-Number: 43510
Gerrit-PatchSet: 11
Gerrit-Owner: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Mon, 12 Apr 2021 09:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment