Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75628?usp=email )
Change subject: mb/google/myst: Correct CROS_WP_GPIO to active high ......................................................................
mb/google/myst: Correct CROS_WP_GPIO to active high
HW has invert the signal, set it to active high.
BUG=b:285964562 TEST=check crossystem wpsw_cur change as expected.
Signed-off-by: Eric Lai eric_lai@quanta.corp-partner.google.com Change-Id: I54c578e5df5f1b24743cc9506e1e31b0b18bfb25 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75628 Reviewed-by: Jon Murphy jpmurphy@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Van Patten timvp@google.com Reviewed-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com --- M src/mainboard/google/myst/chromeos.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Ivy Jian: Looks good to me, approved Tim Van Patten: Looks good to me, approved build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved
diff --git a/src/mainboard/google/myst/chromeos.c b/src/mainboard/google/myst/chromeos.c index e488e81..83ff403 100644 --- a/src/mainboard/google/myst/chromeos.c +++ b/src/mainboard/google/myst/chromeos.c @@ -8,6 +8,6 @@
static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, GPIO_DEVICE_NAME), - CROS_GPIO_WP_AL(CROS_WP_GPIO, GPIO_DEVICE_NAME), + CROS_GPIO_WP_AH(CROS_WP_GPIO, GPIO_DEVICE_NAME), }; DECLARE_CROS_GPIOS(cros_gpios);