John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43657 )
Change subject: soc/intel/tigerlake: Disable VT-d and no DMAR table for pre-QS platform
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43657/4/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43657/4/src/soc/intel/tigerlake/rom...
PS4, Line 200: m_cfg->TcssDma0En || m_cfg->TcssDma1En
TcssDma0 is grouped with Pcie root ports 0/1 and TcssDma1 together with Pcie 2/3. […]
TcssDmaX is actually referred to as USB4/Thunderbolt controller. Their acpi device names are associated as TcssDma0->TDM0 and TcssDma1->TDM1. Please ignore the name confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98a9f6df185002a4e68eaa910f867acd0b96ec2b
Gerrit-Change-Number: 43657
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lalithambika Krishnakumar
lalithambika.krishnakumar@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 04:38:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment