[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake/romstage: Increase size of postcar stack

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )

Change subject: soc/intel/skylake/romstage: Increase size of postcar stack
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/33434/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33434/1//COMMIT_MSG@9 
PS1, Line 9: I increase the size oof the postcar stack to prevent a stack overflow
of

https://review.coreboot.org/#/c/33434/1//COMMIT_MSG@14 
PS1, Line 14: measured boot. To prevent this, the stack size should be increased. To
verifying

I am not so familiar about measured boots, you say postcar is verifying 'romstage'? We have generally used ROMSTAGE_RAM_STACK_SIZE 0x5000 for postcar.

Typically, it's the unlzma() that eats a lot of stack, and I am surprised that 1 KiB ever worked here.