Attention is currently required from: Arthur Heymans, Benjamin Doron, Patrick Rudolph.
David Milosevic has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79108?usp=email )
Change subject: mb/emulation/qemu-sbsa: Generate PPTT ACPI table ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/emulation/qemu-sbsa/pptt.c:
https://review.coreboot.org/c/coreboot/+/79108/comment/d127ec2d_61e01f19?usp... : PS7, Line 9: #define CACHE_NODE_FLAGS 0xd7 // everything valid except, write-policy and allocation type : #define CLUSTER_FLAGS 0x11 // physical package, ID invalid, no thread, no leaf, identical impl. : #define CORE_FLAGS 0x1a // no physical package, ID valid, no thread, leaf, identical impl. : : #define CACHE_ATTR_TYPE_DATA (0) : #define CACHE_ATTR_TYPE_INSTRUCTION (0x1 << 2) : #define CACHE_ATTR_TYPE_UNIFIED (0x1 << 3)
Would it make sense to have this in the header exposing acpi_get_pptt_topology?
The first three definitions are rather mainboard specific. One could put the latter three in the acpi headers but I guess that would be a thing for another separate patch.