[coreboot-gerrit] New patch to review for coreboot: 109d6e5 haswell boards: Enable VIRTUAL_DEV_SWITCH

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4220

-gerrit

commit 109d6e52d063336ada7a64f8756d9c63ff617bb7
Author: Duncan Laurie 
Date:   Mon Jun 3 10:45:08 2013 -0700

haswell boards: Enable VIRTUAL_DEV_SWITCH

This config option was not enabled which was preventing
    the user from enabling developer mode from recovery mode.

With this enabled we can disable the "dev mode by default"
    behavior and let people enable it by entering recovery mode.

This will make the firmware behave like a typical chromeos
    device.

Peppy is left in "default dev mode" until after bringup.

1) boot slippy in normal mode by default
    2) enter recovery mode with servo button
    3) Ctrl+D on USB keyboard to enter developer mode
    4) boot slippy in developer mode

Change-Id: I414c0d10dd0489e3c89798f75a2872a43297c8d8
    Signed-off-by: Duncan Laurie 
    Reviewed-on: https://gerrit.chromium.org/gerrit/57350
    Reviewed-by: Aaron Durbin 
---
 src/mainboard/google/falco/Kconfig     | 1 +
 src/mainboard/google/falco/chromeos.c  | 2 +-
 src/mainboard/google/peppy/Kconfig     | 1 +
 src/mainboard/google/slippy/Kconfig    | 1 +
 src/mainboard/google/slippy/chromeos.c | 2 +-
 5 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/falco/Kconfig b/src/mainboard/google/falco/Kconfig
index 3a08086..3c0c576 100644
--- a/src/mainboard/google/falco/Kconfig
+++ b/src/mainboard/google/falco/Kconfig
@@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_SOFTWARE_SYNC
+	select VIRTUAL_DEV_SWITCH
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/falco/chromeos.c b/src/mainboard/google/falco/chromeos.c
index 1b70fde..51d625b 100644
--- a/src/mainboard/google/falco/chromeos.c
+++ b/src/mainboard/google/falco/chromeos.c
@@ -83,7 +83,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 /* The dev-switch is virtual */
 int get_developer_mode_switch(void)
 {
-	return 1;
+	return 0;
 }

/* There are actually two recovery switches. One is the magic keyboard chord,
diff --git a/src/mainboard/google/peppy/Kconfig b/src/mainboard/google/peppy/Kconfig
index 5eb8b95..74a04fb 100644
--- a/src/mainboard/google/peppy/Kconfig
+++ b/src/mainboard/google/peppy/Kconfig
@@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_SOFTWARE_SYNC
+	select VIRTUAL_DEV_SWITCH
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index a53ac00..aaea947 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_SOFTWARE_SYNC
+	select VIRTUAL_DEV_SWITCH
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/slippy/chromeos.c b/src/mainboard/google/slippy/chromeos.c
index 1b70fde..51d625b 100644
--- a/src/mainboard/google/slippy/chromeos.c
+++ b/src/mainboard/google/slippy/chromeos.c
@@ -83,7 +83,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 /* The dev-switch is virtual */
 int get_developer_mode_switch(void)
 {
-	return 1;
+	return 0;
 }

/* There are actually two recovery switches. One is the magic keyboard chord,