Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37872 )
Change subject: biostar/a68n_5200: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 12:
Please note, I tested patchset 11 and have no plans to test the hw beyond this.
I don't know why you needed to remove those two includes, it didn't seem to compile without them on my end. If it passes jenkins, and you're happy to merge an untested commit, go for it, but I suggest merging version 11.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e710ac61843c09a055523c7971e4c05bae56a37
Gerrit-Change-Number: 37872
Gerrit-PatchSet: 12
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jan 2020 07:35:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment