Attention is currently required from: Felix Singer, Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )
Change subject: soc/intel/common/systemagent: Improve systemagent ......................................................................
Patch Set 12:
(6 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/1b926cf3_347e3df9?usp... : PS10, Line 146: value = ALIGN_DOWN(value, 1 * MiB);
If a register is with low 20+ bits reserved (cannot be written into), the align down to 1MB operatio […]
Shouldn't the 1MB align down still be kept?
https://review.coreboot.org/c/coreboot/+/83318/comment/3e203674_29b1149f?usp... : PS10, Line 78: return;
Can you move ln77 to ln84?
Done
https://review.coreboot.org/c/coreboot/+/83318/comment/4d9d31cf_b157f84e?usp... : PS10, Line 135: .align = CONFIG_TOUUD_ALIGNMENT,
No need to add align here
Done
https://review.coreboot.org/c/coreboot/+/83318/comment/f6bb99af_8ad4d08a?usp... : PS10, Line 178: value = ALIGN_DOWN(value, entry->align);
if (entry->is_limit) { […]
Done
File src/soc/intel/common/block/systemagent/systemagent_def.h:
https://review.coreboot.org/c/coreboot/+/83318/comment/1720cdee_2ff66536?usp... : PS3, Line 73: * IS_LIMIT = If registers/offset indicates address limit or address limit plus 1.
fixup_limit
Done
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/b64fa632_a0f8dc96?usp... : PS10, Line 138: return ALIGN_DOWN(tolud, CONFIG_TOLUD_ALIGNMENT);
if (CONFIG(SA_MEMMAP_FIXUP_LIMIT)) […]
Done