Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48954 )
Change subject: soc/mediatek/mt8192: pmic: unlock key protection before initial setting ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48954/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48954/11//COMMIT_MSG@9 PS11, Line 9: We need unlock key protection so that some initial settings could be effective. Line too long (> 72 chars).
https://review.coreboot.org/c/coreboot/+/48954/11/src/soc/mediatek/mt8192/mt... File src/soc/mediatek/mt8192/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/48954/11/src/soc/mediatek/mt8192/mt... PS11, Line 323: { No curly braces.