[coreboot-gerrit] Change in coreboot[master]: mb/google/herobrine: Initialize USB by calling SOC method

[Julius Werner (Code Review)]

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56093 )

Change subject: mb/google/herobrine: Initialize USB by calling SOC method
......................................................................

Patch Set 34:

(2 comments)

File src/mainboard/google/herobrine/mainboard.c:

https://review.coreboot.org/c/coreboot/+/56093/comment/a88b390e_441e6490 
PS34, Line 19: void mainboard_blob_fix(void);
What is this and what does it have to do with this patch?

https://review.coreboot.org/c/coreboot/+/56093/comment/ad57c000_cd6c95fe 
PS34, Line 23: usb0_board_data
If the SNPS doesn't use any board_data, just pass NULL (and don't define a struct for it that is never used).