build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )
Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2 ......................................................................
Patch Set 2:
(69 comments)
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 82: gpio_set_pull(GPIO(MISC_BSI_CK_3), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 83: gpio_set_pull(GPIO(PERIPHERAL_EN9), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 158: {INIT_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 159: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 162: {INIT_CMD, 6, {0x00, 0x08, 0x01, 0xf4, 0x01, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 163: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 165: {INIT_CMD, 6, {0x00, 0x0c, 0x00, 0x00, 0x00, 0x03}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 166: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 169: {INIT_CMD, 6, {0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 170: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 171: {INIT_CMD, 6, {0x00, 0x20, 0x15, 0x92, 0x56, 0x7d}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 172: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 173: {INIT_CMD, 6, {0x00, 0x24, 0x00, 0x00, 0x30, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 174: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 179: {INIT_CMD, 6, {0x10, 0x08, 0x01, 0x20, 0x04, 0x45}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 180: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 181: {INIT_CMD, 6, {0x10, 0x1c, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 182: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 183: {INIT_CMD, 6, {0x20, 0x0c, 0x00, 0x00, 0x00, 0x04}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 184: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 186: {INIT_CMD, 6, {0x20, 0x10, 0x00, 0x4b, 0x00, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 187: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 188: {INIT_CMD, 6, {0x20, 0xa0, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 189: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 191: {INIT_CMD, 6, {0x60, 0x08, 0x00, 0xd9, 0x00, 0x08}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 192: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 193: {INIT_CMD, 6, {0x60, 0x14, 0x01, 0x00, 0x01, 0x06}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 194: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 196: {INIT_CMD, 6, {0x60, 0x80, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 197: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 199: {INIT_CMD, 6, {0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 200: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 203: {INIT_CMD, 6, {0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 204: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 206: {INIT_CMD, 6, {0x60, 0x10, 0x08, 0x00, 0x14, 0x50}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 207: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 209: {INIT_CMD, 6, {0x60, 0x84, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 210: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 211: {INIT_CMD, 6, {0x60, 0xa4, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 212: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 215: {INIT_CMD, 2, {0xff, 0x01}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 216: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 217: {INIT_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 218: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 219: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 220: {INIT_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 221: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 222: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 223: {INIT_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 224: {INIT_DCS_CMD, 1, {00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 228: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 229: {INIT_DCS_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 230: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 231: {INIT_DCS_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 232: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 258: false, &edid, lcm_init_cmd, sizeof(lcm_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/mainboard/google/kukui/mainboard... PS2, Line 261: false, &edid, lcm_p097pfg_ssd2858_init_cmd, sizeof(lcm_p097pfg_ssd2858_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@371 PS2, Line 371: while(read32(&dsi->dsi_intsta) & (1 << 31)) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@372 PS2, Line 372: printk(BIOS_ERR, "mtk_dsi_cmdq wait dsi no busy\n"); Prefer using '"%s...", __func__' to using 'mtk_dsi_cmdq', this function's name, in a string
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@376 PS2, Line 376: printk(BIOS_ERR, "mtk_dsi_cmdq dsi no busy\n"); Prefer using '"%s...", __func__' to using 'mtk_dsi_cmdq', this function's name, in a string
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@400 PS2, Line 400: dsi_clrsetbits_le32((void *)DSI_BASE + 0x200 + ((cmdq_off + i) & (0xfffffffc)), line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@421 PS2, Line 421: printk(BIOS_ERR, "dump_dsi_reg : reg[0x%x] = 0x%x\n", i, read32((void *)DSI_BASE + i)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@423 PS2, Line 423: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x60] = 0x%x\n", read32((void *)DSI_BASE + 0x60)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@424 PS2, Line 424: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x00] = 0x%x\n", read32((void *)DSI_BASE)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@425 PS2, Line 425: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x14] = 0x%x\n", read32((void *)DSI_BASE + 0x14)); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@448 PS2, Line 448: printk(BIOS_ERR, "delay : init_cmd[%d].len = 0x%x\n", i, init_cmd[i].len); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@457 PS2, Line 457: printk(BIOS_ERR, "INIT_DCS_CMD : init_cmd[i].len = 0, init_cmd[%d].data[0] = 0x%x\n", i, init_cmd[i].data[0]); line over 80 characters
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@521 PS2, Line 521: for (i = 0; i < 0x208; i = i + 4) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32097/2/src/soc/mediatek/mt8183/dsi.c@522 PS2, Line 522: printk(BIOS_ERR, "dump_dsi_reg : reg[ox%x] = 0x%x\n", i, read32((void *)DSI_BASE + i)); line over 80 characters