Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83992?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Add USB port descriptions ......................................................................
mb/lenovo/thinkcentre_m710s: Add USB port descriptions
Change-Id: Icc5546a8073c03ce77480b634b367d10d1ad0111 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83992 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/mainboard/lenovo/thinkcentre_m710s/Kconfig M src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb 2 files changed, 114 insertions(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig index 799e689..c01aaec 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig +++ b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig @@ -5,6 +5,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select DRIVERS_USB_ACPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb index 3eae806..bce93ae 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb +++ b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb @@ -34,7 +34,6 @@ // Used by the SD/MMC reader. [11] = USB2_PORT_MID(OC_SKIP), // F_USB2 (Pins 5, 7) }" - register "usb3_ports" = "{ [0] = USB3_PORT_DEFAULT(OC1), // USB30A [1] = USB3_PORT_DEFAULT(OC1), // USB30B @@ -43,6 +42,119 @@ [4] = USB3_PORT_DEFAULT(OC3), // F_USB30_2A [5] = USB3_PORT_DEFAULT(OC3), // F_USB30_2B }" + + chip drivers/usb/acpi + register "desc" = ""xHCI Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""USB30A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 1)" + device usb 2.0 on end + end + chip drivers/usb/acpi + register "desc" = ""USB30B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device usb 2.1 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_1A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 2.2 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_1B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device usb 2.3 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_2A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(3, 1)" + device usb 2.4 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_2B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(3, 2)" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""M.2 Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.6 on end + end + chip drivers/usb/acpi + register "desc" = ""USB_LANA"" + register "type" = "UPC_TYPE_A" + register "group" = "ACPI_PLD_GROUP(4, 1)" + device usb 2.7 on end + end + chip drivers/usb/acpi + register "desc" = ""USB_LANB"" + register "type" = "UPC_TYPE_A" + register "group" = "ACPI_PLD_GROUP(4, 2)" + device usb 2.8 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB1 (Pins 5, 7)"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(5, 1)" + device usb 2.9 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB1 (Pins 6, 8)"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(5, 2)" + device usb 2.10 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB2 (Pins 5, 7)"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.11 on end + end + chip drivers/usb/acpi + register "desc" = ""USB30A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 1)" + device usb 3.0 on end + end + chip drivers/usb/acpi + register "desc" = ""USB30B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device usb 3.1 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_1A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 3.2 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_1B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device usb 3.3 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_2A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(3, 1)" + device usb 3.4 on end + end + chip drivers/usb/acpi + register "desc" = ""F_USB30_2B"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(3, 2)" + device usb 3.5 on end + end + end + end end device ref thermal on end device ref heci1 on end