Attention is currently required from: Jason Glenesk, Marshall Dawson, Rob Barnes, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58963 )
Change subject: src/cpu,soc/amd/common/block/cpu: Add preload_microcode
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/cpu/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/58963/comment/2b0b9da2_2bda2f2e
PS1, Line 132: printk(BIOS_DEBUG, "Preloading microcode\n");
nit: Printing CPU_MICROCODE_BLOB_NAME here would be helpful for debugging.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58963
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0c634c692c97769e71acd1175fc464dc592c356
Gerrit-Change-Number: 58963
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Nov 2021 20:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment