Attention is currently required from: Amanda Hwang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63495 )
Change subject: mb/google/brya/var/brya0: Change MAX98360 AMP interface to I2S1
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/63495/comment/19c7d3e4_61599f6c
PS3, Line 143: if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))) {
since I2S0 not used here, you can i2s0_disable_pads
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ee45dbceabdedd39a9befffb8002b8bc3d4bfb4
Gerrit-Change-Number: 63495
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 14:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment