[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h

[Julius Werner (Code Review)]

Attention is currently required from: Angel Pons, Alex James.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )

Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

File util/cbfstool/cbfs_image.c:

https://review.coreboot.org/c/coreboot/+/60233/comment/bd99fcbf_715ac377 
PS6, Line 528: uint32_t type = htobe32(cur->type);
             : 
             : 		/* Current entry is empty. Kepp track of it. */
             : 		if ((type == htobe32(CBFS_TYPE_NULL)) ||
             : 		    (type == htobe32(CBFS_TYPE_DELETED))) {
> Yeah...

Feel free to fix it if you want to... a lot of this code is very old and never really gets any attention.

https://review.coreboot.org/c/coreboot/+/60233/comment/e6defdb5_03a9f5c5 
PS6, Line 1031: be32toh(stage->loadaddr)
> Seems like a mistake? be64toh(stage->loadaddr) is used everywhere else in this file.

My mistake (from CB:46484), thanks for catching! Please fix it while we're here.