Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39313 )
Change subject: soc/intel/tigerlake: Correct order of "RUN_FSP_GOP" check
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39313/3/src/soc/intel/tigerlake/gra...
File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/39313/3/src/soc/intel/tigerlake/gra...
PS3, Line 69: }
Is it applicable only for JSL. I see CNL is also doing the same.
we observed hang when Display is not connected in JSL. Because GOP is also programming "ddi_buf_ctl" we need to check that why we didn't face this problem in previous platforms.
But as description suggest this should execute if VBIOS or GOP do not execute.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32692501b60f48a07b8fbb9bb3a755b18f4b3ea9
Gerrit-Change-Number: 39313
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Mar 2020 15:34:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment