Attention is currently required from: Michał Żygowski, Angel Pons, Piotr Król.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59888 )
Change subject: mainboard: Drop `SataMode` setting from Skylake devicetrees
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Should we remove the devicetree setting completely? This looks like something that should be user-co […]
This should be an user-configurable setting, right, but not sure if it should be done with CMOS or Kconfig. In my opinion CMOS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9be5eca93cac65afc4cc30ceb64d9a5b7e5cd514
Gerrit-Change-Number: 59888
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 10 Dec 2021 21:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment