Attention is currently required from: Paul Menzel, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84409?usp=email )
Change subject: mb/google/fatcat: Add HDA verb tables ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84409/comment/b1b68428_59a91462?usp... : PS1, Line 10: TEST=Boot on google fatcat board
Tested how?
Done
File src/mainboard/google/fatcat/variants/fatcat/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84409/comment/78440bcc_fb6f9f15?usp... : PS1, Line 57: * Disable AGC and set AGC limit to -1.5dB
`please, no space before tabs` […]
Done
https://review.coreboot.org/c/coreboot/+/84409/comment/c9ba5a16_f44d6dff?usp... : PS1, Line 57: * Disable AGC and set AGC limit to -1.5dB
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/84409/comment/e54d3b51_c4655da8?usp... : PS1, Line 79: /* Widget node 0x20 - 6 : * Silence data mode Threshold (-90dB) */
The recommended concise style is: […]
Done