Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Add pcie root complex driver
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb...
File src/soc/amd/picasso/northbridge.c:
https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb...
PS31, Line 41: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
I agree. I filed b/156946266 to understand what the 12MB before TOM is. […]
My guess is that 12MiB might be CC6 for saving core state, though I don't think the cpu can directly address that part of the physical address space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a4a97765151fbcfe4c5d8de200e3e015aaaf2e
Gerrit-Change-Number: 34424
Gerrit-PatchSet: 35
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Wed, 20 May 2020 19:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment