HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43709 )
Change subject: src/soc/qualcomm: Add include <types.h> ......................................................................
Patch Set 1:
(4 comments)
I've added comments to make the review easy
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/ipq40xx/in... File src/soc/qualcomm/ipq40xx/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/ipq40xx/in... PS1, Line 19: BIT(8) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/qcs405/usb... File src/soc/qualcomm/qcs405/usb.c:
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/qcs405/usb... PS1, Line 203: BIT(1) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/qcom_qup_se.h:
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/sc7180/inc... PS1, Line 13: BIT(l) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/sc7180/qup... File src/soc/qualcomm/sc7180/qupv3_spi.c:
https://review.coreboot.org/c/coreboot/+/43709/1/src/soc/qualcomm/sc7180/qup... PS1, Line 34: BIT(2) needs <types.h>