[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68961 )

Change subject: soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device
......................................................................

soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device

Don't set bit 2 in _STA in order for Windows not to show a warning about
an unknown device in the device manager for this device. Since the _STA
object just returns a constant, a name definition can be used instead of
a method definition.

TEST=The unknown device with device instance path ACPI\AAHB0000\0
disappeared from the device manager in Windows 10 build 19045 on a
Mandolin board with a Picasso APU.

Just shutting down and then booting it again won't clear some internal
state in Windows, so a reboot is needed instead for the change to become
visible.

Signed-off-by: Felix Held 
Change-Id: I8cb1712756c3623cc3ea16210af69cde0fa18f62
---
M src/soc/amd/cezanne/acpi/mmio.asl
M src/soc/amd/glinda/acpi/mmio.asl
M src/soc/amd/mendocino/acpi/mmio.asl
M src/soc/amd/morgana/acpi/mmio.asl
M src/soc/amd/picasso/acpi/sb_fch.asl
M src/soc/amd/stoneyridge/acpi/sb_fch.asl
6 files changed, 29 insertions(+), 30 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/68961/1

diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl
index fa43db0..a109f53 100644
--- a/src/soc/amd/cezanne/acpi/mmio.asl
+++ b/src/soc/amd/cezanne/acpi/mmio.asl
@@ -14,11 +14,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)
diff --git a/src/soc/amd/glinda/acpi/mmio.asl b/src/soc/amd/glinda/acpi/mmio.asl
index 05653e5..07ff790 100644
--- a/src/soc/amd/glinda/acpi/mmio.asl
+++ b/src/soc/amd/glinda/acpi/mmio.asl
@@ -16,11 +16,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)
diff --git a/src/soc/amd/mendocino/acpi/mmio.asl b/src/soc/amd/mendocino/acpi/mmio.asl
index 5544016..c4acfb1 100644
--- a/src/soc/amd/mendocino/acpi/mmio.asl
+++ b/src/soc/amd/mendocino/acpi/mmio.asl
@@ -16,11 +16,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)
diff --git a/src/soc/amd/morgana/acpi/mmio.asl b/src/soc/amd/morgana/acpi/mmio.asl
index 51a7cbd..f52f0e8 100644
--- a/src/soc/amd/morgana/acpi/mmio.asl
+++ b/src/soc/amd/morgana/acpi/mmio.asl
@@ -16,11 +16,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl
index 7ab3b17..d58e044 100644
--- a/src/soc/amd/picasso/acpi/sb_fch.asl
+++ b/src/soc/amd/picasso/acpi/sb_fch.asl
@@ -14,11 +14,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)
diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
index 212a111..d7490d7 100644
--- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl
+++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
@@ -12,11 +12,7 @@
    {
    	Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
    })
-
-	Method (_STA, 0x0, NotSerialized)
-	{
-		Return (0x0F)
-	}
+	Name (_STA, 0xb)
 }

Device (GPIO)