Attention is currently required from: Benjamin Doron, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81938?usp=email )
Change subject: soc/intel/alderlake: Enable Early CrashLog support
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/81938/comment/6b620bcb_bf27450a :
PS1, Line 28: /* Set CrashLog BARs (FIXME: Is there a second BAR here? Documentation doesn't say so) */
don't u need to disable the MMIO and temp BAR before assigning the new one?
https://review.coreboot.org/c/coreboot/+/81938/comment/95e2eb91_e3fb0639 :
PS1, Line 38: /* Clear CrashLog BARs */
disable the memory before clearing the BAT other wise some transaction might fail in between
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81938?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ce47531a74486bc5c996f7793af7087bc30d1f7
Gerrit-Change-Number: 81938
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 16 Apr 2024 05:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment