ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: WIP: Add configurable ramstage support for minimal PCI scanning ......................................................................
Patch Set 14:
Patch Set 14:
Here's another thought, how we could avoid trouble: Instead of opting out of minimal-scanning per device, we could opt in. For instance, if MINIMAL_PCI_SCANNING is enabled, use a pci_dev_optional_read_resource() by default, and every driver that supports it, could use it too, but would have to do so explicitly.
I'm not sure. I think I'd rather have people indicate that they really need to be scanned, with the ..._always function. It will be a bit too easy for people to avoid the opt int.
But I'm not sure I know.
I think it boils down to the question if you want the author of a patch that enables minial scanning or the reviewer to do the work:
- opt-in: Author has to look into each driver and decide if it can be enabled.
- opt-out: Reviewer gets to check every affected driver if it doesn't run into undefined behaviour.
ok, I get the point. Overall this will make it a bit more work for people who want to try minimal scanning out, but at the same time, there are very few people, I guess, who want to try minimal scanning out :-)
I'll look at that tomorrow, it will basically flip the sense of the code but should not be a big deal and should do what you suggest.