Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42864 )
Change subject: sb/intel: Factor out soc_fill_gnvs() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42864/3/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/42864/3/src/southbridge/intel/bd82x... PS3, Line 664: acpi_create_gnvs(gnvs); Implementation of acpi_create_gnvs() is under mb/ so the changed order here would seem preferable.
I was about to initialise GNVS prior to SMM module loader, but that dev_count_cpu() call has to be done after MP init.
Only the fields of GNVS that smihandler has references to, need to be initialised prior to first SMI trigger (after relocation). Perhaps there are none, I did not check yet.