[coreboot-gerrit] Change in coreboot[master]: drivers/ipmi: make IPMI KCS status and command register spacing confi...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34835 )

Change subject: drivers/ipmi: make IPMI KCS status and command register spacing configurable
......................................................................

drivers/ipmi: make IPMI KCS status and command register spacing configurable

The default is 1 (byte) spacing.

Tested on Mono Lake with 4 (32-bit) spacing

Change-Id: I47412c32e6db8f58b4fde8150adcbce349ca18a7
Signed-off-by: Johnny Lin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34835
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/drivers/ipmi/Kconfig
M src/drivers/ipmi/ipmi_kcs.c
2 files changed, 9 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/drivers/ipmi/Kconfig b/src/drivers/ipmi/Kconfig
index 5851438..0f7152d 100644
--- a/src/drivers/ipmi/Kconfig
+++ b/src/drivers/ipmi/Kconfig
@@ -1,3 +1,10 @@
 config IPMI_KCS
    bool
    default n
+
+config IPMI_KCS_REGISTER_SPACING
+	int
+	default 1
+	depends on IPMI_KCS
+	help
+	  KCS status and command register IO port address spacing
diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c
index 397a800..4d1e3e1 100644
--- a/src/drivers/ipmi/ipmi_kcs.c
+++ b/src/drivers/ipmi/ipmi_kcs.c
@@ -36,9 +36,9 @@
 #define IPMI_KCS_STATE_WRITE 0x02
 #define IPMI_KCS_STATE_ERROR 0x03

-#define IPMI_CMD(_x) ((_x) + 1)
+#define IPMI_CMD(_x) ((_x) + CONFIG_IPMI_KCS_REGISTER_SPACING)
 #define IPMI_DATA(_x) ((_x))
-#define IPMI_STAT(_x) ((_x) + 1)
+#define IPMI_STAT(_x) ((_x) + CONFIG_IPMI_KCS_REGISTER_SPACING)

static unsigned char ipmi_kcs_status(int port)
 {