Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44355 )
Change subject: soc/intel/tigerlake: Allow fine grained control of S0iX states ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44355/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44355/6//COMMIT_MSG@9 PS6, Line 9: Expose FSP parameter to enable/disable each individual substate.
This change doesn't really expose FSP parameter, but provides a knob for mainboard to selectively di […]
Ack
https://review.coreboot.org/c/coreboot/+/44355/6/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/44355/6/src/soc/intel/tigerlake/chi... PS6, Line 69:
tab instead of space
Done
https://review.coreboot.org/c/coreboot/+/44355/6/src/soc/intel/tigerlake/chi... PS6, Line 70:
same here
Done