Attention is currently required from: Angel Pons, Felix Singer, Philipp Hug, Ron Minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74570?usp=email )
Change subject: arch/risc/mcall.h: Make the stack pointer global
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74570/comment/0ffe2744_616b7ac1 :
PS4, Line 10: remediated
be remediated
Done
https://review.coreboot.org/c/coreboot/+/74570/comment/7a4907fc_b943c1b9 :
PS4, Line 10: Change
Change... […]
Done
Patchset:
PS4:
No idea how this is supposed to work. Has it been tested?
Risc-v support is broken since ~4 years. TESTED with the fix https://review.coreboot.org/c/coreboot/+/36486/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74570?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24602372833aa9d413bf396853b223263fd873ed
Gerrit-Change-Number: 74570
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 17:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment