build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31270 )
Change subject: intel/spi: Define PCI accessor aliases only once ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31270/2/src/include/device/pci_compat.h File src/include/device/pci_compat.h:
https://review.coreboot.org/#/c/31270/2/src/include/device/pci_compat.h@20 PS2, Line 20: #define pci_read_config_byte(dev, reg, targ)\ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31270/2/src/include/device/pci_compat.h@22 PS2, Line 22: #define pci_read_config_word(dev, reg, targ)\ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31270/2/src/include/device/pci_compat.h@24 PS2, Line 24: #define pci_read_config_dword(dev, reg, targ)\ Macros with complex values should be enclosed in parentheses