Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65932 )
Change subject: payloads/edk2: Add the recipes to assemble UniversalPayload
......................................................................
Patch Set 42:
(1 comment)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/65932/comment/af677ef3_2f165843
PS42, Line 204: CONFIG_EDK2_REPO_MRCHROMEBOX=$(CONFIG_EDK2_REPO_MRCHROMEBOX) \
We can add them back later if still needed, but for now lets remove it first? :)
Understood now after explanation from Sean,it in there in case someone selects it, it'll error reasonably. Without it, the repo can be undefined and it just melts. Can adjust in the follow up commit. Thanks Sean
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6363c92f8155007e05c682694d7413fd4630b6d
Gerrit-Change-Number: 65932
Gerrit-PatchSet: 42
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 21 Oct 2022 16:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment