Attention is currently required from: Jérémy Compostella, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84174?usp=email )
Change subject: src/{incl/cpu, soc/intel/cmn}: Add Extended Feature Enable Register Macro
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
same feedback why this CL is not at main tot and inside PTL recipe ?
Moved to TOT.
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/84174/comment/0b536251_27390373?usp... :
PS4, Line 64:
Hi, these bits belogs to (POWER_CTL) – Offset 1fc […]
I have moved the Offset 1fc definition to src/soc/intel/common/block/include/intelblocks/msr.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7be9a43a51bc52300e66cbf736c3e3275714b13b
Gerrit-Change-Number: 84174
Gerrit-PatchSet: 6
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 06:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com