Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email )
Change subject: acpi: Set checksum for SPCR table ......................................................................
acpi: Set checksum for SPCR table
This was missed recently when adding the table. Linux complains about the missing checksum, e.g.
[ 0.186070] ACPI BIOS Warning (bug): Incorrect checksum in table [SPCR] - 0x00, should be 0x87 (20210730/tbprint-173)
Tested with QEMU/Q35, albeit with changes to the special handling for ACPI with QEMU. The warning goes away.
Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2 Signed-off-by: Nico Huber nico.h@gmx.de Fixes: commit 90464073e4a1 (acpi: Add SPCR table) Reviewed-on: https://review.coreboot.org/c/coreboot/+/76158 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index e0e72f7..267a989 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1866,6 +1866,8 @@ spcr->language = 0; spcr->pci_did = 0xffff; spcr->pci_vid = 0xffff; + + header->checksum = acpi_checksum((void *)spcr, header->length); }
unsigned long __weak fw_cfg_acpi_tables(unsigned long start)