Attention is currently required from: Xi Chen, CK HU, Yidi Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44717 )
Change subject: soc/mediatek/mt8192: Do write leveling training
......................................................................
Patch Set 57:
(3 comments)
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44717/comment/f67172c0_bdcdcbf8
PS57, Line 4220: 0x80
nit: `1 << 7` would be more self-explanatory
https://review.coreboot.org/c/coreboot/+/44717/comment/d637fc05_b0f6b3b7
PS57, Line 4222: 0x7f
Same as above, this could be `~(1 << 7)`
https://review.coreboot.org/c/coreboot/+/44717/comment/16114e6b_42fddfe4
PS57, Line 4271: set_dram_mr_write_leveling
Shouldn't this function be called twice? Once to enable WL mode, and once to exit WL mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44717
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf4f5d07eb8ef1d0d99ad106f497fea5f60c8a97
Gerrit-Change-Number: 44717
Gerrit-PatchSet: 57
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: CK HU
ck.hu@mediatek.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 20:48:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment