[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: add generic DDR4 SPDs for Eldrid

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )

Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid
......................................................................

Patch Set 66:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... 
File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... 
PS59, Line 9: SPD_SOURCES += ddr4-spd-2.hex      # ID = 2(0b0010)  Parts = H5ANAG6NCMR-XNC
> NOTE that this SPD has changed based on a recent DDR4 SPD tool fix (https://review.coreboot. […]

I rebased this patch on top of the others to assure ddr4-spd-2-hex is correct when this CL merges.

https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... 
File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:

https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... 
PS66, Line 4: ,3
            : K4AAG165WA-BCWE,4
            : MT40A1G16KD-062E:E,5
> Why are the rest of the parts assigned fixed IDs? I think only 0,1,2 were used for the previous buil […]

Because it was requested.  Please see bug.