Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 20:
(408 comments)
File util/coreboot-configurator/obj-x86_64-linux-gnu/meson-logs/meson-log.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9e700e06_1ae6a027 PS20, Line 63: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/38393922_5fc1a28a PS20, Line 66: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c20d527d_a12b93e3 PS20, Line 69: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0e3c9fe9_21476b0d PS20, Line 72: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/24f6d954_3145b6db PS20, Line 79: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpovryma0u/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpovryma0u/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Core -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/047bbe31_86d0206a PS20, Line 85: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d1e644af_dd64f47e PS20, Line 87: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3f7f1c_36616bc6 PS20, Line 90: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dc84ac6a_27c89db4 PS20, Line 93: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e027b407_07bf7602 PS20, Line 96: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c8dd5423_09bf7063 PS20, Line 99: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b0a45da0_518dfa4e PS20, Line 106: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpkbtd4eu8/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpkbtd4eu8/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Gui -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ed9b615_b3feebf0 PS20, Line 112: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/52598b46_db7657df PS20, Line 114: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/532abafe_d4ed1115 PS20, Line 117: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cd3d7ce7_23551c0a PS20, Line 120: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3931933c_f50aece6 PS20, Line 123: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1816143_06f04f57 PS20, Line 126: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8bce49e0_33a68595 PS20, Line 133: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpl5ncokvu/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpl5ncokvu/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Widgets -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a220826d_d53c63b8 PS20, Line 139: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/98bf07b0_36970c98 PS20, Line 141: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ea71a07f_90b245e5 PS20, Line 144: PKG_CONFIG_PATH: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cae7e4dd_5dc5ee91 PS20, Line 157: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmph5nfr_d_/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmph5nfr_d_/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5bd642ba_72899f02 PS20, Line 161: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cb55f6c6_061a4eeb PS20, Line 167: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d9c3be2b_414ba69e PS20, Line 169: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/86fdff6b_0e11ddd5 PS20, Line 179: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmp8dng8htx/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmp8dng8htx/output.obj -pipe -c -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive --print-search-dirs trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a9d6b090_cfa8aa8e PS20, Line 182: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/35586590_65fa845c PS20, Line 189: trailing whitespace
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/61f49e8d_c54d0948 PS20, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c2453aa_aa930dae PS20, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9ee18736_891896dd PS20, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f51a2fce_d8d59e96 PS20, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/categories.yaml:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a11b7e8b_a6e84197 PS20, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'?
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e82d2f6c_fd2397fb PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b6635c8c_81249548 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6c7a2362_d3b684c4 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1df9f47_e7823631 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/34d387e7_ba39dcc8 PS20, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/876d5a1e_3878ce1e PS20, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ed22bbd0_73bccbbd PS20, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b7b9929d_1eeee485 PS20, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ade8a663_c51e1eb5 PS20, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f5b58fc_201ae41d PS20, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9306ec6_a70df7d8 PS20, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5e4c2d70_e2a1a0af PS20, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aef9fa0d_52e6e0f1 PS20, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9d9c3df1_cc38bd3d PS20, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/32d3b1a8_4776b16c PS20, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c8c07494_6d92393e PS20, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca689c76_0df0e09d PS20, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c90b66a2_96e57a1e PS20, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/305ff8ab_f14807f2 PS20, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b34e3ee6_0379cc8b PS20, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/31cac6b6_ca2dd173 PS20, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/084aedca_532a9649 PS20, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f5e10c8_bc333323 PS20, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c61b247_32a46e83 PS20, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1bd7d4ca_a19b0852 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/adb199c5_920f6b31 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a722d10e_a209e247 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6fe45d3_899a061e PS20, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af342db4_5457e2cb PS20, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c83a1314_b736eedc PS20, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20f8c084_de6263d9 PS20, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d025b380_a7601089 PS20, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f7cd6d3_555d1ffb PS20, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/601fc2c1_81870d7a PS20, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9b296bb8_7a9f907b PS20, Line 25: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/82da9209_992d0224 PS20, Line 207: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/471247f1_8795593b PS20, Line 413: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'?
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca8659d9_d84b516c PS20, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6161a3f_a49bfc40 PS20, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1331e39a_bbba36bc PS20, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e118ad05_3522f029 PS20, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/97fefd72_b09c5dff PS20, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b53d4c77_38b4b757 PS20, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ccb308da_b0bb2221 PS20, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/50df73c3_9b34b914 PS20, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/602694b9_aa83e412 PS20, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a284108_97d8cd72 PS20, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/25dcffff_d0d3a859 PS20, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7bd47959_84a12fb1 PS20, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b6589a4_443c4c6c PS20, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d8556575_175daf84 PS20, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b74e40a_b29fb1c5 PS20, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b73f53a_278a621c PS20, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fe181bac_2477a350 PS20, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0d823aa1_62378778 PS20, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f2b3739_8830b94c PS20, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c753209e_79f3a57c PS20, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1f23a2d1_fc101eb1 PS20, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a852bc1_1a71ffcc PS20, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9decb6bf_8f8c17ae PS20, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b48e54cf_c5112993 PS20, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/99d0011f_638059c3 PS20, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a9a3eddf_3063451a PS20, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c0005e92_30dd0119 PS20, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ccf4be4e_558197d7 PS20, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ecc3c04b_5371ff58 PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/eb24b579_509fe335 PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/651289ad_9b5aec9f PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d94b0472_4099dfb8 PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/25f62453_1ff2fd8a PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa121c5d_351e2c6c PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b2b99f18_20c8c89d PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a8137132_501ef2cc PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d22cc2ba_bfba393f PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ffdc416_ed688306 PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/65aee7df_9fd7d811 PS20, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b7e05fe7_077af571 PS20, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1dd6a2cc_bef8d8aa PS20, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ce4588_9679de84 PS20, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/feef0c48_a5eef723 PS20, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63207dcc_add7f88f PS20, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/54cbc71b_93692aa2 PS20, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/04531b34_f5817e74 PS20, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4a1f3707_defa4d54 PS20, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/39ea04fe_155a1cee PS20, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1c0e6183_a643d61c PS20, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/06aa79d7_9a76f9cf PS20, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ae16d56_4181e0da PS20, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3fb4d9db_48cc076b PS20, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a9e04ad_e6b52d29 PS20, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/236e337c_3ae3217c PS20, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/031f562f_a5f88ebd PS20, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8b0c4c1a_c11ccdfb PS20, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bb7f060d_235e5a71 PS20, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4557744b_f33750b1 PS20, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d7ea5d27_8cdd49a3 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/649e47d3_0f1c5f95 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9705435f_4e2380fb PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a3392ff_5340b059 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3513ba0f_15650070 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5155895_d12b7332 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f93bfd66_0c5fb2f1 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20de607e_c59efa03 PS20, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3a49ef93_7f9bf83f PS20, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/602915fa_18625bf8 PS20, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a5a2d2b8_a90e1d8e PS20, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e7322d31_becc7d53 PS20, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a1c36c0c_945a772b PS20, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/12bfa88e_c7411e6d PS20, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aea7c339_36e82815 PS20, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/56165d4c_4f45d26b PS20, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ae40cf27_11a92b49 PS20, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f35de309_714627c0 PS20, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4d210985_16f0a164 PS20, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f6cc3d4_b95b427e PS20, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa838332_185d8966 PS20, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/41abd37f_8eea7e65 PS20, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b68c2a_08cb778a PS20, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cdff8a29_c370488d PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c23144e_0b8955c7 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0b10cf2a_2887b3aa PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/adb7f793_20bf7242 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/93445607_fb6a51ce PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f76ee023_7ac57077 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/773a77f6_0652c937 PS20, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2c6bf312_c7d2c204 PS20, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa8c444a_0caf1280 PS20, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/64fa5782_31390a2a PS20, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cf61069d_155b5efc PS20, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7d740d25_4da290c6 PS20, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f39a7b61_d7cc85aa PS20, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/62223e57_639d1dba PS20, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6ba039f_c4b17a76 PS20, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1c89e1c3_39c7382a PS20, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ba2e1393_fde43085 PS20, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/67c165f3_091bc4fd PS20, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/842ad27b_50f3dbb8 PS20, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0c3b2790_dc86ec86 PS20, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b00cf2d9_6a2bcc36 PS20, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f1915ea7_a3739c97 PS20, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/81cd6ea5_bf831ba5 PS20, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/abeaf498_db6e2c43 PS20, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b1bd50ae_32414f04 PS20, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/14a0426f_c2813b76 PS20, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/098081fa_1260aaf7 PS20, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/482702c5_6a70b2e7 PS20, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3b03a752_b6e60bf8 PS20, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/929cf5fd_903db172 PS20, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bb059a2b_02a84b85 PS20, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c69f1f64_6538cbbe PS20, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4b7decca_29b64129 PS20, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3c393eec_eaec9a2c PS20, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0974d7a3_90ffa77c PS20, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/14f5cdd7_5b5add26 PS20, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8625c937_38876af0 PS20, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2d4bec96_f5ddd43c PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d02b4fce_47d88767 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9f9e1ec1_c78b685f PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6d3b63f_245bb1c4 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d45ab1c9_a14f3ca2 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/abfb8254_f0a49ccf PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bad2ae66_a8941fd7 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cec15dd8_c146e11c PS20, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b4e1afc2_6c6272e4 PS20, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/050db54c_8377c305 PS20, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4c28a871_149f52d8 PS20, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4f60c31_7fc1b3c1 PS20, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4cda8288_51ea5033 PS20, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6dcba24_97b22797 PS20, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/560d6034_909a994a PS20, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5eb586d2_ea04478c PS20, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f1c47db_a16e1430 PS20, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0d217f44_d136d05b PS20, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b2d76e33_df764aea PS20, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f203c389_5d3de0c2 PS20, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/211d07ac_8227ce38 PS20, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2af4008b_8a40835a PS20, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/10f9c1e6_077f767c PS20, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc14576_393359d4 PS20, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/08756c66_cd7a5cb4 PS20, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af031e3f_edfdcf67 PS20, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63044ac5_2f1dc45a PS20, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/00b35e6d_4d6f8f82 PS20, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5ffedc_33eea4ac PS20, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/60d5bb91_6ef1e68f PS20, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7aaaa077_0c385262 PS20, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b0c3ed2a_7572ea83 PS20, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb0894b_e1192496 PS20, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5c90980_044aa96a PS20, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/60a21925_1549647a PS20, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f4209d2c_da1ee36f PS20, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cbd9bead_7d331e67 PS20, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/037d4522_a04f03a0 PS20, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f91fa718_ecf8b351 PS20, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8009a8e9_92546c00 PS20, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca88862c_0df60e0b PS20, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6ee84703_f2f529b6 PS20, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/827dcb8b_9bbf730f PS20, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f3a5c1d0_dc4cb5fb PS20, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9799d48_aa8d6c24 PS20, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/df25dc94_64a05bd1 PS20, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d7d33cc8_84cfacb5 PS20, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/43416fdd_64dcc5af PS20, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0cef94b6_7b5bb180 PS20, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/33e275a9_96a312ff PS20, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8f2ef7e2_8e346fe1 PS20, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4059dfae_215d07e5 PS20, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6cafa5d5_d6c43440 PS20, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/200e5eea_bdd4563f PS20, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e6238242_d64ef474 PS20, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f2c4478_36d508fa PS20, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b96cd4d9_56811fd0 PS20, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/21b4ee24_ec6eeaf3 PS20, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/720aa35c_e799811f PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/88c01283_f4d3502c PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/504227f4_785bcb31 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3719f2b6_e8cea1b6 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/95a5e654_aa483757 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/82eb7a35_4601efef PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1369f211_fc762573 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f8834e3_9b9d4840 PS20, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ff6ff3c7_443c3a3d PS20, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/48500d20_55cd36e2 PS20, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f2b63077_fde6fe21 PS20, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dd8f5efa_4baef09c PS20, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e4f4323b_f4520109 PS20, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1092a053_d340b266 PS20, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fcdb7c20_52b96a21 PS20, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/43e501c8_6b7af385 PS20, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a63df27_ca533dc9 PS20, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/36a3de8c_b929a441 PS20, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cdc4ea02_da2cc721 PS20, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/66d41acd_d2c2bd74 PS20, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e1064f71_10b4965a PS20, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5bf598f_00507bce PS20, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ce4a2429_4b432c7e PS20, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d2dba64_f7737d74 PS20, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ae084e4_5f188735 PS20, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/259ab38a_9533dd3c PS20, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8c5b7bb4_42b91eed PS20, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6370070_75ce8003 PS20, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af78de69_6a77dcc6 PS20, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/61247ff6_c61c9d90 PS20, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e6fbf306_58e9c26c PS20, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dfdb6ab9_7fa8ddf7 PS20, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/549c8160_974d4089 PS20, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3b9730d6_0dcab98b PS20, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/076a15f5_f07c037d PS20, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1532ff87_05e59672 PS20, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f9ebfc4c_83e93d85 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2bb82fd2_f5b944f5 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b64c92c9_6f038fda PS20, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6a8f883_f7511760 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4bf0b3a8_2c6a8cc9 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/151c737e_ae9b3cad PS20, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b457e1d3_e8edb3c5 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/057eac85_267dc9e9 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/324bba89_36819041 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f708b6d_bc189b4c PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9eb34f4b_9f5660fc PS20, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20cffe4b_de7a1c36 PS20, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aa4c5373_686d4b9a PS20, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a1d7f966_b6a29fe0 PS20, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a971c10e_fd8213f8 PS20, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b77b5f4_1d44f482 PS20, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/76f494f4_53846331 PS20, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/187ad05f_32d327da PS20, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3ba8b7_3630b911 PS20, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4e64539c_fc42e2b9 PS20, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/881310e4_292eca6f PS20, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/686eca2d_0160963a PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/65a398be_f35f9860 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4cbd4da_fc277c5f PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e5641d78_efca9014 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/77978672_72d6e2b7 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3d441806_35be224c PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ee71c2e_6d4812de PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b574fbb4_82dd9a05 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa94c6ff_4e01a93d PS20, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/89e2655a_626d4050 PS20, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f446f164_c6b93f43 PS20, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2d1f3d58_5e5c0c8d PS20, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca70bc0b_3746b476 PS20, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/12021470_a1c5ef07 PS20, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/84ac420a_79fb9cef PS20, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2158d4de_caea4bca PS20, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9962042_1ff471d4 PS20, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7ab43175_e7f427bb PS20, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7a0e6cfb_47ca726d PS20, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/96a6b5df_9729a625 PS20, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3ab8ca65_e039000b PS20, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8426fc4c_7b0eac46 PS20, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5571095b_9244bc0b PS20, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/09b21bd5_29f9d4dd PS20, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6228cc6c_4711d0f7 PS20, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aebb9346_52ae5093 PS20, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/72677a22_69f09edd PS20, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1fe16c2_a35f63d7 PS20, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d2c1c1c_2cda7ff3 PS20, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e99abd_180966d1 PS20, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1828277b_167fcf68 PS20, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a8e5a26b_48d71bdc PS20, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/74dd3de1_d2eafd09 PS20, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e395dabc_95a97ddf PS20, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d677759a_3973dbc9 PS20, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5827f182_9ee3c647 PS20, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ff241c78_355eb7c2 PS20, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/db9d738c_c23ddb1e PS20, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6a53a76b_49a4f5af PS20, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/05e51102_1bc1bc84 PS20, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/62148830_912f2fc1 PS20, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/79f6170e_8a5d75a5 PS20, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6fc48d69_66c90720 PS20, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d5523ab_709aff6c PS20, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0e38d3ac_8ddf7007 PS20, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ec6e3b03_7df6913d PS20, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/de67daa3_536cff87 PS20, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a37ec8c6_93dc9cbd PS20, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ff76156_92669618 PS20, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef6e66d_e607c0de PS20, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6b61ba1a_f2a3fc91 PS20, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bdb1c35c_c9f0c247 PS20, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e8a2b1a7_98dec32d PS20, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/daa28435_dcdea975 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/51a7347f_492811d0 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1d117d0e_ec080567 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6b527968_da6d19a8 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6cbe88bb_bfad1e54 PS20, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c9a08db8_442b5527 PS20, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c87364a6_f6b9d5a9 PS20, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5769b670_44f478a4 PS20, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1d2c0f67_dbc3bb99 PS20, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4df9ce7c_cfded5f9 PS20, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cc353228_77debaef PS20, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2df06fd9_1bd84132 PS20, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0224d6aa_53cb85d7 PS20, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63be89ce_d7da2afe PS20, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/627b3d74_2518497f PS20, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba46ea5_4daae872 PS20, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a42a43c0_f7328774 PS20, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d668fcfe_96acd574 PS20, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c9506fd0_a85f12af PS20, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6580be79_eeb035a2 PS20, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/77b97bde_39d435eb PS20, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/76b666b4_7aaadef7 PS20, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/02af3d6a_db21ae04 PS20, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dd899dc0_f4414253 PS20, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ea989a87_02deb6fb PS20, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e83bb037_d94748eb PS20, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9cc0bd48_1a6df38a PS20, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fe2f01f5_39bf7fde PS20, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/67eca69a_23375fe4 PS20, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/54b44953_aaa11bf4 PS20, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/086f00a7_d961603c PS20, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cc79e118_786edba1 PS20, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d5772020_b1344eba PS20, Line 12: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/666376d9_90dce83b PS20, Line 13: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/203a6054_5b904c1e PS20, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/062806b6_c12ebd04 PS20, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3c567174_b69ebbce PS20, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/733ea58d_bbacf29e PS20, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/596a484c_b21eec2c PS20, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d67dd0f4_bf0e7ad7 PS20, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/091d0a1d_b6888d20 PS20, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c69d622b_b94bc9f5 PS20, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aee97ef7_353b5def PS20, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/964e1085_dd7d1fcc PS20, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/13af89e1_dfc1e15e PS20, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4391415_6b60cfd0 PS20, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0c7940d4_7a53c404 PS20, Line 32: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6e45907d_8d1d6b72 PS20, Line 33: //needs to be clickable on code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/587a0272_f0fa51ab PS20, Line 34: return rect().contains(pos); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f76525d_8ef40f17 PS20, Line 34: return rect().contains(pos); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/565b9604_b41805d0 PS20, Line 35: } please, no spaces at the start of a line