Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76033?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortBDdc dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortBDdc dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortBDdc" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I2dcf35e72bf200837c76bcedc63c3a9a01062552 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb M src/mainboard/protectli/vault_cml/devicetree.cb 6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/76033/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 3b01655..e266c43 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -58,7 +58,7 @@ register DdiPortBHpd = true register DdiPortCHpd = true # Enable DDC for DDI port B - register "DdiPortBDdc" = "1" + register DdiPortBDdc = true
# Disable iDisplay codec enumeration register PchHdaIDispCodecDisconnect = true diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 6e47bb9..734d6f2 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -47,7 +47,7 @@ register DdiPortBHpd = true register DdiPortCHpd = true # Enable DDC for DDI port B - register "DdiPortBDdc" = "1" + register DdiPortBDdc = true
# VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 8d318db..6133586 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -50,7 +50,7 @@ register DdiPortBHpd = true register DdiPortCHpd = true # Enable DDC for DDI port B - register "DdiPortBDdc" = "1" + register DdiPortBDdc = true
register "LanWakeFromDeepSx" = "0" register "WolEnableOverride" = "0" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index a961e95..d4ceed2 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -10,7 +10,7 @@ register DdiPortDHpd = true register DdiPortFHpd = true # Enable DDC for DDI ports B/C - register "DdiPortBDdc" = "1" + register DdiPortBDdc = true register "DdiPortCDdc" = "1" register "DdiPortDDdc" = "1" register "DdiPortFDdc" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index 48a6a19..db85fa3 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -10,7 +10,7 @@ register DdiPortDHpd = true register DdiPortFHpd = true # Enable DDC for DDI ports B/C/D/F - register "DdiPortBDdc" = "1" + register DdiPortBDdc = true register "DdiPortCDdc" = "1" register "DdiPortDDdc" = "1" register "DdiPortFDdc" = "1" diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb index c21c34a..395e2a1 100644 --- a/src/mainboard/protectli/vault_cml/devicetree.cb +++ b/src/mainboard/protectli/vault_cml/devicetree.cb @@ -27,7 +27,7 @@ register DdiPortCHpd = true # USB Type-C
# Enable DDC for DDI port B - register "DdiPortBDdc" = "1" # HDMI + register DdiPortBDdc = true # HDMI
register PchHdaAudioLinkHda = true