Meng-Huan Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48113 )
Change subject: libpayload: Provide API to expose MMU memery ranges for ARM64 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48113/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48113/2//COMMIT_MSG@13 PS2, Line 13: * Provide empty API for x86 and arm.
Do we need this? I don't think it's useful to pretend that this API is universal, because MMU stuff […]
Got it. I simplified this CL, because if we keep get_mmu_ranges() in arm64-specific headers, we probably don't need to move mmu_range structure, given we will need "ifdef" when calling it. Do you intend to use "ifdef" at caller side? or any suggestion?
Depthcharge CL for reference: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...
https://review.coreboot.org/c/coreboot/+/48113/2/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm64/mmu.c:
https://review.coreboot.org/c/coreboot/+/48113/2/payloads/libpayload/arch/ar... PS2, Line 709: const struct mmu_ranges *lib_get_mmu_ranges(void)
The common prefix here is mmu_ so I'd just call this mmu_get_ranges() or something.
Done