Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80764?usp=email )
Change subject: mb/google/nissa/var/glassway: Add GPIO table
......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80764/comment/dced157e_e12ec48a :
PS1, Line 7: Initialize
Add
Done
https://review.coreboot.org/c/coreboot/+/80764/comment/81ecce60_ab8ea2e8 :
PS1, Line 7: gpio
GPIO
Done
https://review.coreboot.org/c/coreboot/+/80764/comment/af1ac500_bae4044a :
PS1, Line 9: devicetree
GPIO
Done
https://review.coreboot.org/c/coreboot/+/80764/comment/79599bcc_39b5d9cb :
PS1, Line 9: Refer
Refer to
Done
File src/mainboard/google/brya/variants/glassway/gpio.c:
https://review.coreboot.org/c/coreboot/+/80764/comment/4fa6bb8d_a87e4049 :
PS1, Line 9: nivviks
I believe we need to correct this project to avoid the confusion.
Modified to "glassway".
https://review.coreboot.org/c/coreboot/+/80764/comment/517aba51_c760265b :
PS1, Line 73: nivviks
Same as above, please correct this project name
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0de743746160c6eb081cb9a061ac1703b01ba5b4
Gerrit-Change-Number: 80764
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 27 Feb 2024 03:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Shawn Ku
shawnku@google.com
Gerrit-MessageType: comment